govulncheck: use golang:1.24 as a base image by xcoulon · Pull Request #166 · codeready-toolchain/toolchain-cicd

xcoulon · 2026-01-30T10:54:49Z

all active repositories have migrated to Go 1.24

also, local build is now called govulncheckx to distinguish from the official govulncheck

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Summary by CodeRabbit

Chores
- Binary renamed from govulncheck to govulncheckx
- Go toolchain updated to version 1.24.0

_{✏️ Tip: You can customize this high-level summary in your review settings.}

all active repositories have migrated to Go 1.24 also, local build is now called `govulncheckx` to distinguish from the official `govulncheck` Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

coderabbitai · 2026-01-30T10:55:05Z

Walkthrough

The PR updates the Go base image in the Containerfile from 1.23.0 to 1.24.0 and simplifies the makefile by renaming the binary output to govulncheckx while removing git commit and build timestamp tracking logic.

Changes

Cohort / File(s)	Summary
Containerfile Update `govulncheck-action/Containerfile`	Updated base image from `golang:1.23.0` to `golang:1.24.0`.
Build Configuration `govulncheck-action/makefile`	Renamed binary output from `govulncheck` to `govulncheckx` in build and install targets; removed `GIT_COMMIT_ID_SHORT` and `BUILD_TIME` variable calculations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

govulncheck: update Go before running the vuln checks #161: Updates the same Containerfile and makefile, incrementing Go version and adjusting binary naming.
govulncheck: run from a Container #159: Introduces the multi-stage Containerfile with Go 1.23 that this PR updates to Go 1.24.

Suggested reviewers

MatousJobanek
alexeykazakov
mfrancisc

Poem

🐰 A newer Go arrives today,
Hopping versions out of way,
Binary renamed with style so grand,
Simpler builds across the land,
Our toolchain hops to tomorrow's way!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: updating the Dockerfile base image from golang:1.23.0 to golang:1.24.0.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

govulncheck-action/Containerfile (1)
15-19: ⚠️ Potential issue | 🔴 Critical

Change the base image tag from golang:1.24.0 to golang:1.24.12 (or golang:1.24)—the 1.24.0 tag does not exist.

The golang:1.24.0 tag is not available on Docker Hub; as of January 2026, the latest patch in the 1.24 line is 1.24.12. This will cause the Docker build to fail when pulling the base image. Use golang:1.24.12 or the floating tag golang:1.24 instead.

Also update the stale comment on line 18 that references Go 1.23.0:
Suggested fix
-FROM golang:1.24.0
+FROM golang:1.24.12
 # using a fresh golang image without the `WORKDIR` from the builder stage
 # see https://docs.github.com/en/actions/reference/workflows-and-actions/dockerfile-support#workdir
-# using golang 1.23.0 since most of our projects are still using it (and toolchain will not downgrade the version of go)
+# using golang 1.24.12 since most of our projects are now using it (and toolchain will not downgrade the version of Go)

xcoulon · 2026-01-30T13:26:11Z

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
govulncheck-action/Containerfile (1)> 15-19: ⚠️ Potential issue | 🔴 Critical
Change the base image tag from golang:1.24.0 to golang:1.24.12 (or golang:1.24)—the 1.24.0 tag does not exist.
The golang:1.24.0 tag is not available on Docker Hub; as of January 2026, the latest patch in the 1.24 line is 1.24.12. This will cause the Docker build to fail when pulling the base image. Use golang:1.24.12 or the floating tag golang:1.24 instead.
Also update the stale comment on line 18 that references Go 1.23.0:

Suggested fix
-FROM golang:1.24.0
+FROM golang:1.24.12
 # using a fresh golang image without the `WORKDIR` from the builder stage
 # see https://docs.github.com/en/actions/reference/workflows-and-actions/dockerfile-support#workdir
-# using golang 1.23.0 since most of our projects are still using it (and toolchain will not downgrade the version of go)
+# using golang 1.24.12 since most of our projects are now using it (and toolchain will not downgrade the version of Go)

the 1.24.0 tag exists:

$ skopeo list-tags docker://golang | grep '1.24.0'
        "1.24.0",
        "1.24.0-alpine",
        "1.24.0-alpine3.20",
        "1.24.0-alpine3.21",
        "1.24.0-bookworm",
        "1.24.0-bullseye",
        "1.24.0-nanoserver",
        "1.24.0-nanoserver-1809",
        "1.24.0-nanoserver-ltsc2022",
        "1.24.0-nanoserver-ltsc2025",
        "1.24.0-windowsservercore",
        "1.24.0-windowsservercore-1809",
        "1.24.0-windowsservercore-ltsc2022",
        "1.24.0-windowsservercore-ltsc2025",

govulncheck: use golang:1.24 as a base image

3e247a1

all active repositories have migrated to Go 1.24 also, local build is now called `govulncheckx` to distinguish from the official `govulncheck` Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

coderabbitai bot reviewed Jan 30, 2026

View reviewed changes

MatousJobanek approved these changes Jan 30, 2026

View reviewed changes

Merge branch 'master' into govulncheck_go_1_24

cc04084

xcoulon merged commit d7a00e6 into codeready-toolchain:master Jan 30, 2026
3 checks passed

xcoulon deleted the govulncheck_go_1_24 branch January 30, 2026 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

govulncheck: use golang:1.24 as a base image#166

govulncheck: use golang:1.24 as a base image#166
xcoulon merged 2 commits intocodeready-toolchain:masterfrom
xcoulon:govulncheck_go_1_24

xcoulon commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

xcoulon commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

xcoulon commented Jan 30, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

xcoulon commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xcoulon commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2026 •

edited

Loading